dtenedor commented on code in PR #36960:
URL: https://github.com/apache/spark/pull/36960#discussion_r912280372
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala:
##########
@@ -1673,6 +1673,120 @@ class InsertSuite extends DataSourceTest with
SharedSparkSession {
}
}
+ test("SPARK-39557 INSERT INTO statements with tables with array/struct/map
defaults") {
Review Comment:
Sounds good, done.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala:
##########
@@ -485,6 +485,28 @@ case class Literal (value: Any, dataType: DataType)
extends LeafExpression {
toDayTimeIntervalString(i, ANSI_STYLE, startField, endField)
case (i: Int, YearMonthIntervalType(startField, endField)) =>
toYearMonthIntervalString(i, ANSI_STYLE, startField, endField)
+ case (data: GenericArrayData, arrayType: ArrayType) =>
+ val arrayValues: Array[String] =
+ data.array.map {
+ Literal(_, arrayType.elementType).sql
+ }
+ s"ARRAY(${arrayValues.mkString(", ")})"
+ case (row: GenericInternalRow, structType: StructType) =>
+ val structValues: Array[String] =
+ row.values.zip(structType.fields.map(_.dataType)).map {
+ case (value: Any, fieldType: DataType) =>
+ Literal(value, fieldType).sql
+ }
+ s"STRUCT(${structValues.mkString(", ")})"
Review Comment:
Good idea, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
