HeartSaVioR commented on code in PR #37042:
URL: https://github.com/apache/spark/pull/37042#discussion_r912281653
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala:
##########
@@ -44,6 +44,14 @@ trait SQLQueryTestHelper {
.replaceAll("Last Access.*", s"Last Access $notIncludedMsg")
.replaceAll("Partition Statistics\t\\d+", s"Partition
Statistics\t$notIncludedMsg")
.replaceAll("\\*\\(\\d+\\) ", "*") // remove the WholeStageCodegen
codegenStageIds
+
+ // Below is needed since the catalog table in LogicalRelation can
produce serde class
+ // "optionally" if CatalogTable is presented and has a serde information
in the storage.
+ // This assumes LogicalRelation contains a catalog table, otherwise it
would not match with
+ // this pattern.
+ .replaceAll("Arguments: (?<relation>.+), (?<attr>\\[(.+#x)(, .+#x)?\\]),
" +
Review Comment:
I'm OK either way. I feel odd to have a config to just satisfy the test
code, but if it leads the code simpler and makes everyone be happy, why not?
I'll reflect the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
