panbingkun commented on code in PR #37031:
URL: https://github.com/apache/spark/pull/37031#discussion_r912440255
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -217,7 +219,7 @@ private case object MySQLDialect extends JdbcDialect with
SQLConfHelper {
// The only property we are building here is `COMMENT` because
it's the only one
// we can get from `SHOW INDEXES`.
val properties = new util.Properties();
- if (indexComment.nonEmpty) properties.put("COMMENT", indexComment)
Review Comment:
I will close it, but maybe we need add some UT for it.I will open new pr for
it.
> FYI: Whether it is necessary to implement createIndex & existIndex &
dropIndex & listIndex in H2Dialet ?
> I found the above "possible null pointer" when implementing the method:
listIndex in H2Dialect(the default value is null instead of empty string).
@huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
