HyukjinKwon commented on code in PR #37066: URL: https://github.com/apache/spark/pull/37066#discussion_r912685317
########## docs/README.md: ########## @@ -61,7 +61,7 @@ See also https://issues.apache.org/jira/browse/SPARK-35375. --> ```sh -$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc sphinx-plotly-directive 'jinja2<3.0.0' +$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc sphinx-plotly-directive pyarrow 'jinja2<3.0.0' 'markupsafe==2.0.1' 'docutils<0.18.0' Review Comment: That's fine. You can just mention like "`dev/requirements.txt` includes all packages for developement so this is the easiest way to install them". (feel free to rephrase it) ########## docs/README.md: ########## @@ -61,7 +61,7 @@ See also https://issues.apache.org/jira/browse/SPARK-35375. --> ```sh -$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc sphinx-plotly-directive 'jinja2<3.0.0' +$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc sphinx-plotly-directive pyarrow 'jinja2<3.0.0' 'markupsafe==2.0.1' 'docutils<0.18.0' Review Comment: That's fine. You can just mention like "`dev/requirements.txt` includes all packages for development so this is the easiest way to install them". (feel free to rephrase it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
