beliefer commented on code in PR #37047:
URL: https://github.com/apache/spark/pull/37047#discussion_r913514346
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala:
##########
@@ -31,34 +33,43 @@ private object DB2Dialect extends JdbcDialect {
url.toLowerCase(Locale.ROOT).startsWith("jdbc:db2")
// See https://www.ibm.com/docs/en/db2/11.5?topic=functions-aggregate
- override def compileAggregate(aggFunction: AggregateFunc): Option[String] = {
- super.compileAggregate(aggFunction).orElse(
- aggFunction match {
- case f: GeneralAggregateFunc if f.name() == "VAR_POP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"VARIANCE($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "VAR_SAMP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"VARIANCE_SAMP($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "STDDEV_POP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"STDDEV($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "STDDEV_SAMP" =>
- assert(f.children().length == 1)
- val distinct = if (f.isDistinct) "DISTINCT " else ""
- Some(s"STDDEV_SAMP($distinct${f.children().head})")
- case f: GeneralAggregateFunc if f.name() == "COVAR_POP" &&
f.isDistinct == false =>
- assert(f.children().length == 2)
- Some(s"COVARIANCE(${f.children().head}, ${f.children().last})")
- case f: GeneralAggregateFunc if f.name() == "COVAR_SAMP" &&
f.isDistinct == false =>
- assert(f.children().length == 2)
- Some(s"COVARIANCE_SAMP(${f.children().head}, ${f.children().last})")
- case _ => None
+ private val supportedAggregateFunctions =
+ Set("VAR_POP", "VAR_SAMP", "STDDEV_POP", "STDDEV_SAMP", "COVAR_POP",
"COVAR_SAMP")
+ private val supportedFunctions = supportedAggregateFunctions
+
+ override def isSupportedFunction(funcName: String): Boolean =
+ supportedFunctions.contains(funcName)
+
+ class DB2SQLBuilder extends JDBCSQLBuilder {
Review Comment:
`JDBCSQLBuilder` already check `supportedFunctions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
