dongjoon-hyun commented on code in PR #37096:
URL: https://github.com/apache/spark/pull/37096#discussion_r914282181
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala:
##########
@@ -65,23 +67,19 @@ object TPCDSQueryBenchmark extends SqlBasedBenchmark with
Logging {
"web_returns", "web_site", "reason", "call_center", "warehouse",
"ship_mode", "income_band",
"time_dim", "web_page")
- def setupTables(dataLocation: String, createTempView: Boolean): Map[String,
Long] = {
+ def setupTables(dataLocation: String, tableColumns: Map[String,
StructType]): Map[String, Long] =
tables.map { tableName =>
- if (createTempView) {
Review Comment:
Do you know the reason why we use `createTempView =
!benchmarkArgs.cboEnabled` before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
