dongjoon-hyun commented on code in PR #37086:
URL: https://github.com/apache/spark/pull/37086#discussion_r914446291
##########
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:
##########
@@ -562,10 +562,6 @@ public UnsafeSorterIterator getSortedIterator() throws
IOException {
}
}
- @VisibleForTesting boolean hasSpaceForAnotherRecord() {
Review Comment:
Thank you for making a PR, but I'd not remove this. Although this is not
used currently, this was added once inevitably. I feel this removal might be
too hasty decision because `UnsafeExternalSorter` is designed to be based on
`UnsafeInMemorySorter` and `UnsafeInMemorySorter.hasSpaceForAnotherRecord()` is
a useful public method. It still looks okay to me to have this
`VisibleForTesting` method to expose the underlying structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
