grundprinzip commented on code in PR #37075:
URL: https://github.com/apache/spark/pull/37075#discussion_r914475557
##########
pom.xml:
##########
@@ -116,7 +116,7 @@
<log4j.version>2.17.2</log4j.version>
<!-- make sure to update IsolatedClientLoader whenever this version is
changed -->
<hadoop.version>3.3.3</hadoop.version>
- <protobuf.version>2.5.0</protobuf.version>
+ <protobuf.version>3.21.1</protobuf.version>
Review Comment:
Absolutely, the shading an relocation rules haven't been updated yet. I'm
still a bit unclear what the best way to progress is to avoid conflicts with
third-party packages or Spark consumers. I've discussed some approaches and one
way would be to produce a shaded spark connect artifact that is then consumed
in it's shaded version by spark itself or to shade and relocate after the build.
However, this PR is mostly for discussing the proto interface.
##########
pom.xml:
##########
@@ -116,7 +116,7 @@
<log4j.version>2.17.2</log4j.version>
<!-- make sure to update IsolatedClientLoader whenever this version is
changed -->
<hadoop.version>3.3.3</hadoop.version>
- <protobuf.version>2.5.0</protobuf.version>
+ <protobuf.version>3.21.1</protobuf.version>
Review Comment:
Absolutely, the shading and relocation rules haven't been updated yet. I'm
still a bit unclear what the best way to progress is to avoid conflicts with
third-party packages or Spark consumers. I've discussed some approaches and one
way would be to produce a shaded spark connect artifact that is then consumed
in it's shaded version by spark itself or to shade and relocate after the build.
However, this PR is mostly for discussing the proto interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
