cloud-fan commented on code in PR #36995:
URL: https://github.com/apache/spark/pull/36995#discussion_r916557149
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala:
##########
@@ -143,4 +150,54 @@ object V2ExpressionUtils extends SQLConfHelper with
Logging {
case V2NullOrdering.NULLS_FIRST => NullsFirst
case V2NullOrdering.NULLS_LAST => NullsLast
}
+
+ def resolveV2ScalarFunction(
+ scalarFunc: ScalarFunction[_],
+ arguments: Seq[Expression]
+ ): Expression = {
+ val declaredInputTypes = scalarFunc.inputTypes().toSeq
+ val argClasses = declaredInputTypes.map(ScalaReflection.dataTypeJavaClass)
+ findMethod(scalarFunc, MAGIC_METHOD_NAME, argClasses) match {
+ case Some(m) if Modifier.isStatic(m.getModifiers) =>
+ StaticInvoke(scalarFunc.getClass, scalarFunc.resultType(),
+ MAGIC_METHOD_NAME, arguments, inputTypes = declaredInputTypes,
+ propagateNull = false, returnNullable = scalarFunc.isResultNullable,
+ isDeterministic = scalarFunc.isDeterministic)
+ case Some(_) =>
+ val caller = Literal.create(scalarFunc,
ObjectType(scalarFunc.getClass))
+ Invoke(caller, MAGIC_METHOD_NAME, scalarFunc.resultType(),
+ arguments, methodInputTypes = declaredInputTypes, propagateNull =
false,
+ returnNullable = scalarFunc.isResultNullable,
+ isDeterministic = scalarFunc.isDeterministic)
+ case _ =>
+ // TODO: handle functions defined in Scala too - in Scala, even if a
+ // subclass do not override the default method in parent interface
+ // defined in Java, the method can still be found from
+ // `getDeclaredMethod`.
+ findMethod(scalarFunc, "produceResult", Seq(classOf[InternalRow]))
match {
+ case Some(_) =>
+ ApplyFunctionExpression(scalarFunc, arguments)
+ case _ =>
+ throw new AnalysisException(s"ScalarFunction
'${scalarFunc.name()}'" +
+ s" neither implement magic method nor override 'produceResult'")
+ }
+ }
+ }
+
+ /**
+ * Check if the input `fn` implements the given `methodName` with parameter
types specified
+ * via `argClasses`.
+ */
+ private def findMethod(
+ fn: BoundFunction,
Review Comment:
nit: 4 spaces indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
