kamcheungting-db commented on code in PR #37104:
URL: https://github.com/apache/spark/pull/37104#discussion_r917070033
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala:
##########
@@ -283,20 +283,7 @@ case class TakeOrderedAndProjectExec(
}
override def executeCollect(): Array[InternalRow] = {
- val orderingSatisfies = SortOrder.orderingSatisfies(child.outputOrdering,
sortOrder)
Review Comment:
In this PR, we are adding more case to benefit from
TakeOrderedAndProjectExec.
is there any reason for us to modify executeCollect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
