huaxingao commented on code in PR #37112:
URL: https://github.com/apache/spark/pull/37112#discussion_r917314224
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -74,6 +77,40 @@ private[sql] object H2Dialect extends JdbcDialect {
functionMap.clear()
}
+ override def createIndex(
Review Comment:
Could you include the link for H2 `CREATE INDEX` here?
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -74,6 +77,40 @@ private[sql] object H2Dialect extends JdbcDialect {
functionMap.clear()
}
+ override def createIndex(
+ indexName: String,
+ tableIdent: Identifier,
+ columns: Array[NamedReference],
+ columnsProperties: util.Map[NamedReference, util.Map[String, String]],
+ properties: util.Map[String, String]): String = {
+ val columnList = columns.map(col => col.fieldNames.head)
Review Comment:
I think we always need to quote the identifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
