cloud-fan commented on code in PR #37001:
URL: https://github.com/apache/spark/pull/37001#discussion_r917712890
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -165,106 +169,63 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper wit
val pushedAggregates =
finalTranslatedAggregates.filter(r.pushAggregation)
if (pushedAggregates.isEmpty) {
aggNode // return original plan node
+ } else if (r.supportCompletePushDown(pushedAggregates.get)) {
+ // If we can push down the aggregation completely, we need
to consider
+ // pushing down the Limit or Offset operator, so keep the
information about
+ // aggregation push down and push down aggregation later.
+ sHolder.pushedAggregation = Some(PushedAggregation(
+ pushedAggregates,
+ finalResultExpressions,
+ finalAggregates,
+ normalizedGroupingExpressions,
+ aggExprToOutputOrdinal))
+ sHolder
Review Comment:
The returned scan builder should change its output to `aggNode.output`
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2ScanRelationPushDown.scala:
##########
@@ -165,106 +169,63 @@ object V2ScanRelationPushDown extends Rule[LogicalPlan]
with PredicateHelper wit
val pushedAggregates =
finalTranslatedAggregates.filter(r.pushAggregation)
if (pushedAggregates.isEmpty) {
aggNode // return original plan node
+ } else if (r.supportCompletePushDown(pushedAggregates.get)) {
+ // If we can push down the aggregation completely, we need
to consider
+ // pushing down the Limit or Offset operator, so keep the
information about
+ // aggregation push down and push down aggregation later.
+ sHolder.pushedAggregation = Some(PushedAggregation(
+ pushedAggregates,
+ finalResultExpressions,
+ finalAggregates,
+ normalizedGroupingExpressions,
+ aggExprToOutputOrdinal))
+ sHolder
Review Comment:
The returned scan builder holder should change its output to `aggNode.output`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
