bzhaoopenstack commented on PR #37117: URL: https://github.com/apache/spark/pull/37117#issuecomment-1180157076
> @bzhaoopenstack Thanks for contributions! > > 1. Rename `[SPARK-39714][python]` to `[SPARK-39714][PYTHON]` : ) > 2. It would be good you can fullfill the PR description even this is a minor fix > > ``` > ./dev/lint-python > // ...... > starting mypy annotations test... > annotations failed mypy checks: > python/pyspark/pandas/indexes/base.py:48: error: Module "pandas._libs" has no attribute "lib" [attr-defined] > python/pyspark/streaming/context.py:372: error: Unused "type: ignore" comment > python/pyspark/streaming/context.py:378: error: Unused "type: ignore" comment > Found 3 errors in 2 files (checked 338 source files) > 1 > (venv) ➜ spark git:(pr/37117) mypy --version > mypy 0.941 > ``` > > In my env, maybe also fix these? Could you also take a look? lint CI are using [mypy==0.920](https://github.com/bzhaoopenstack/spark/runs/7246817397?check_suite_focus=true#step:9:22) I think Yes, my test result with mypy 0.920 with this PR is ``` spark@DESKTOP-U0I7MO9:~/upstream/spark$ dev/lint-python starting python compilation test... python compilation succeeded. The python3 -m black command was not found. Skipping black checks for now. starting flake8 test... flake8 checks passed. starting mypy annotations test... annotations passed mypy checks. starting mypy examples test... examples passed mypy checks. starting mypy data test... annotations passed data checks. all lint-python tests passed! spark@DESKTOP-U0I7MO9:~/upstream/spark$ mypy --version mypy 0.920 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
