LuciferYang commented on code in PR #37163:
URL: https://github.com/apache/spark/pull/37163#discussion_r919652743
##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -209,11 +209,13 @@ class InjectRuntimeFilterSuite extends QueryTest with
SQLTestUtils with SharedSp
// `MergeScalarSubqueries` can duplicate subqueries in the optimized plan
and would make testing
// complicated.
conf.setConfString(SQLConf.OPTIMIZER_EXCLUDED_RULES.key,
MergeScalarSubqueries.ruleName)
+ conf.setConf(SQLConf.CBO_ENABLED, false)
Review Comment:
Seems this line is to keep consistent with the previous behavior, but should
we add some TODO for this change? For example, spilt this Suites into
`withCBOEnabled` and `withCBODisabled`?
I found many suites in this class will fail when `CBOEnabled`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
