cloud-fan commented on code in PR #36150:
URL: https://github.com/apache/spark/pull/36150#discussion_r919718238
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -422,6 +426,15 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
}
metrics.foreach(m => checkMetric(m, m))
+ // see Analyzer.ResolveMelt
+ case m: Melt if m.childrenResolved && m.ids.forall(_.resolved) &&
m.values.isEmpty =>
Review Comment:
I'm not sure if we should do this check here. It's possible that we have not
infer the value columns yet when hitting this rule, and we should wait for
other rules (`ResolveMelt`) to infer value columns first.
I think we should move this check to `CheckAnalysis`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
