ulysses-you commented on PR #37176: URL: https://github.com/apache/spark/pull/37176#issuecomment-1183851038
Follow the previous `PhysicalOperation` semantics, shall we also update this to `NodeWithOnlyDeterministicProjectAndFilter` ? we may miss inject runtime filter if the project of filter side holds some complex expressions. https://github.com/apache/spark/blob/899f6c90eb2de5b46a36710a131d7417010ce4b3/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala#L119-L126 otherwise looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
