LuciferYang commented on code in PR #37185:
URL: https://github.com/apache/spark/pull/37185#discussion_r921084119
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala:
##########
@@ -27,7 +27,7 @@ class GenericArrayData(val array: Array[Any]) extends
ArrayData {
// Specified this as`scala.collection.Seq` because seqOrArray can be
// `mutable.ArraySeq` in Scala 2.13
- def this(seq: scala.collection.Seq[Any]) = this(seq.toArray)
+ def this(seq: scala.collection.Seq[Any]) =
this(GenericArrayDataHelper.toArray(seq))
Review Comment:
> an ArraySeq is a bit larger I think than a native array
Sounds reasonable. Let's evaluate it at that time. It can't be changed yet.
We still need to support two Scala versions now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
