cloud-fan commented on code in PR #37188:
URL: https://github.com/apache/spark/pull/37188#discussion_r922284082
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala:
##########
@@ -518,9 +518,77 @@ private[v2] trait V2JDBCTest extends SharedSparkSession
with DockerIntegrationFu
checkAggregatePushed(df, "CORR")
val row = df.collect()
assert(row.length === 3)
- assert(row(0).getDouble(0) === 1d)
- assert(row(1).getDouble(0) === 1d)
+ assert(row(0).getDouble(0) === 1.0)
+ assert(row(1).getDouble(0) === 1.0)
assert(row(2).isNullAt(0))
}
}
+
+ protected def testRegrIntercept(isDistinct: Boolean = false): Unit = {
+ val distinct = if (isDistinct) "DISTINCT " else ""
+ test(s"scan with aggregate push-down: REGR_INTERCEPT with distinct:
$isDistinct") {
Review Comment:
```suggestion
val distinct = if (isDistinct) " with DISTINCT " else ""
test(s"scan with aggregate push-down: REGR_INTERCEPT$distinct") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
