panbingkun commented on code in PR #37199:
URL: https://github.com/apache/spark/pull/37199#discussion_r922689973
##########
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java:
##########
@@ -208,7 +208,7 @@ public void testExamplesRunnerNoMainClass() throws
Exception {
}
@Test
- public void testExamplesRunnerWithMasterNoMainClass() throws Exception {
Review Comment:
AbstractCommandBuilder.buildClassPath is not test methods.
In fact, When I review launcher module, I found the following **two kinds**
of problems: https://github.com/apache/spark/pull/37199 &
https://github.com/apache/spark/pull/37200
#### Should I close the above two PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
