LuciferYang commented on code in PR #37185: URL: https://github.com/apache/spark/pull/37185#discussion_r922705338
########## sql/catalyst/src/main/scala-2.13/org/apache/spark/sql/catalyst/util/GenericArrayDataHelper.scala: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util + +import scala.collection.immutable +import scala.collection.mutable + +object GenericArrayDataHelper { + + // SPARK-39766: Special treatment of `immutable.ArraySeq[Any]` and `mutable.ArraySeq[Any]` + // to ensure the scenes similar to `arrayOfAnyAsSeq` in `GenericArrayDataBenchmark` have + // the same performance when using Scala 2.12 and Scala 2.13 + def toArray(seq: scala.collection.Seq[Any]): Array[Any] = seq match { + case ias: immutable.ArraySeq.ofRef[_] => ias.unsafeArray.asInstanceOf[Array[Any]] Review Comment: > I'm wondering if we know that the backing array contains the exact contents of the ArraySeq - does it ever have more elements to allow growth? that kind of thing. Maybe WrappedArray does guarantee that. This part seems risky. Growth will not be allowed, and the addition or deletion item of `ArraySeq(both mutable and immutable)` will return a new `ArraySeq`, but there is also a risk: `mutable.ArraySeq.sortInPlace` will sort on the original array, which is a new method in Scala 2.13 and Spark doesn't use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
