EnricoMi commented on code in PR #36150:
URL: https://github.com/apache/spark/pull/36150#discussion_r922713899
##########
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:
##########
@@ -390,6 +390,49 @@ public void testGroupBy() {
Assert.assertEquals(asSet("1a#2", "3foobar#6", "5#10"),
toSet(cogrouped.collectAsList()));
}
+ @Test
+ public void testMelt() {
Review Comment:
I found it always useful to have these tests as they actually call into the
Scala API and proof that this works and is Java-friendly. Otherwise no Java
code uses the method and only users find out it is useless. But the `unpivot`
method signatures look simple and Java-friendly (and tests have proven they are
alright), so I can remove these again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
