HeartSaVioR commented on code in PR #37213:
URL: https://github.com/apache/spark/pull/37213#discussion_r925100892
##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala:
##########
@@ -338,6 +338,7 @@ abstract class KafkaMicroBatchSourceSuiteBase extends
KafkaSourceSuiteBase {
)
// When Trigger.Once() is used, the read limit should be ignored
+ // NOTE: the test uses the deprecated Trigger.Once() by intention, do not
change.
Review Comment:
Probably a good idea for SQL core module but it does not work with
connectors. I'm thinking of another mode of Trigger.AvailableNow to behave like
Trigger.Once for processing available data (deal with one batch ignoring source
options), and then these usages can be replaced with new mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
