cloud-fan commented on code in PR #37216:
URL: https://github.com/apache/spark/pull/37216#discussion_r926547447
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala:
##########
@@ -638,3 +641,66 @@ abstract class TypedImperativeAggregate[T] extends
ImperativeAggregate {
buffer.get(offset, anyObjectType).asInstanceOf[T]
}
}
+
+/**
+ * A special TypedImperativeAggregate that uses `OpenHashMap[AnyRef, Long]` as
internal
+ * aggregation buffer.
+ */
+abstract class AggregationBuffer extends
TypedImperativeAggregate[OpenHashMap[AnyRef, Long]] {
Review Comment:
`AggregationBuffer` is really a bad name. How about
`TypedAggregateWithHashMapAsBuffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
