[GitHub] [spark] yikf opened a new pull request, #37254: [SPARK-39841][SQL] simplify conflict binary comparison

Fri, 22 Jul 2022 05:07:01 -0700 


yikf opened a new pull request, #37254:
URL: https://github.com/apache/spark/pull/37254

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: 
https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a 
faster review.
     7. If you want to add a new configuration, please read the guideline first 
for naming configurations in
        
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the 
guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   Currently, We do not handle conflicting binary comparison expressions, Let's 
say have a query, it filter `a < 0 and a > 1`, this condition should be a 
`FalseLiteral`, we can fold ahead of time to avoid unnecessary calculations.
   
   Before this pr:
   <img width="1439" alt="image" 
src="https://user-images.githubusercontent.com/51110188/180430599-fad13dbe-f8eb-4f13-9a04-77d920eba50b.png";>
   
   After this pr:
   <img width="647" alt="image" 
src="https://user-images.githubusercontent.com/51110188/180435768-3e58435a-3e06-406b-971a-026961438882.png";>
   
   
   
   ### Why are the changes needed?
   Fold ahead to avoid unnecessary calculations & improve performance
   
   
   ### Does this PR introduce _any_ user-facing change?
   No, improve only
   
   ### How was this patch tested?
   Add new tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to