cloud-fan commented on code in PR #37264:
URL: https://github.com/apache/spark/pull/37264#discussion_r928468774
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAsSchemaSuite.scala:
##########
@@ -46,15 +46,11 @@ class DataFrameAsSchemaSuite extends QueryTest with
SharedSparkSession {
checkAnswer(df, Row("b"))
}
- test("negative: column not found") {
Review Comment:
Ah I see, you add a new test for both columns and fields. I think it's
better to keep the old tests because this test suite put column tests one after
each other, then field tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
