HyukjinKwon commented on code in PR #37203:
URL: https://github.com/apache/spark/pull/37203#discussion_r928860500
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -919,8 +925,13 @@ private[spark] object Utils extends Logging {
// created the directories already, and that they are secured so that
only the
// user has access to them.
randomizeInPlace(getYarnLocalDirs(conf).split(","))
- } else if (conf.getenv("SPARK_EXECUTOR_DIRS") != null) {
- conf.getenv("SPARK_EXECUTOR_DIRS").split(File.pathSeparator)
+ } else if (isRunningInK8sContainer(conf)) {
+ // Randomizing the shuffle location in case of K8s so that all disk get
fair changes to
+ // get selected.
+ randomizeInPlace(conf.getenv("SPARK_LOCAL_DIRS").split(","))
Review Comment:
I am still not sure if this really safe to return the randomized directory
whenever this method is invoked. This configuration (spark.local.dir) and
environment variables are meant to be immutable but this is changing it here
for every call during runtime.
Since this relates to the core path in which we should be relatively more
strict, I would suggest to thoroughly investigate all the related paths TBH
since we're breaking the assumption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
