mridulm commented on code in PR #37203:
URL: https://github.com/apache/spark/pull/37203#discussion_r929414978
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -880,6 +880,12 @@ private[spark] object Utils extends Logging {
conf.getenv("CONTAINER_ID") != null
}
+ private[spark] def isRunningInK8sContainer(conf: SparkConf): Boolean = {
+ // Master must start with K8s in case of kubernetes
+ conf.contains("spark.master") && conf.get("spark.master") != null &&
+ conf.get("spark.master").startsWith("k8s://")
Review Comment:
nit: `conf.getOption("spark.master").exists(_.startsWith("k8s://"))` ?
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -919,8 +925,13 @@ private[spark] object Utils extends Logging {
// created the directories already, and that they are secured so that
only the
// user has access to them.
randomizeInPlace(getYarnLocalDirs(conf).split(","))
- } else if (conf.getenv("SPARK_EXECUTOR_DIRS") != null) {
- conf.getenv("SPARK_EXECUTOR_DIRS").split(File.pathSeparator)
+ } else if (isRunningInK8sContainer(conf)) {
+ // Randomizing the shuffle location in case of K8s so that all disk get
fair changes to
+ // get selected.
+ randomizeInPlace(conf.getenv("SPARK_LOCAL_DIRS").split(","))
Review Comment:
QQ: I see both `SPARK_LOCAL_DIRS` and `SPARK_EXECUTOR_DIRS` in use within
k8s resource manager - do we not want to do this for `SPARK_EXECUTOR_DIRS`
@dongjoon-hyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
