beliefer commented on code in PR #37284:
URL: https://github.com/apache/spark/pull/37284#discussion_r929597290
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/EliminateSortsSuite.scala:
##########
@@ -116,10 +116,10 @@ class EliminateSortsSuite extends AnalysisTest {
test("SPARK-33183: remove redundant sort by") {
val orderedPlan = testRelation.select($"a", $"b").orderBy($"a".asc,
$"b".desc_nullsFirst)
- val unnecessaryReordered = orderedPlan.limit(2).select($"a")
+ val unnecessaryReordered = LocalLimit(2, orderedPlan).select($"a")
Review Comment:
If users use LIMIT syntax of SQL or limit(...) of Dataset, will we meet the
issue ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
