beliefer commented on code in PR #37280:
URL: https://github.com/apache/spark/pull/37280#discussion_r929616324
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -126,12 +127,14 @@ object ResolveDefaultColumns {
*
* @param field represents the DEFAULT column value whose "default"
metadata to parse
* and analyze.
+ * @param metadataKey which key to look up from the column metadata;
generally either
+ * CURRENT_DEFAULT_COLUMN_METADATA_KEY or
EXISTS_DEFAULT_COLUMN_METADATA_KEY.
* @param statementType which type of statement we are running, such as
INSERT; useful for errors.
* @return Result of the analysis and constant-folding operation.
*/
- def analyze(field: StructField, statementType: String): Expression = {
+ def analyze(field: StructField, metadataKey: String, statementType: String):
Expression = {
Review Comment:
```suggestion
def analyze(field: StructField, statementType: String, metadataKey: String
= CURRENT_DEFAULT_COLUMN_METADATA_KEY): Expression = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
