beliefer commented on code in PR #37295:
URL: https://github.com/apache/spark/pull/37295#discussion_r930683900
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CombiningLimitsSuite.scala:
##########
@@ -111,7 +111,7 @@ class CombiningLimitsSuite extends PlanTest {
comparePlans(optimized1, expected1)
// test child max row > limit.
- val query2 = testRelation.select().groupBy()(count(1)).limit(0).analyze
+ val query2 =
testRelation2.select($"x").groupBy($"x")(count(1)).limit(1).analyze
Review Comment:
The origin test case want to test child max row > limit. Because it uses
limit value is 0, the new rules will eliminate it.
So I adjust the test case so that still test child max row > limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
