viirya commented on code in PR #37284:
URL: https://github.com/apache/spark/pull/37284#discussion_r930688431
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1430,9 +1430,13 @@ object Limit {
/**
* A global (coordinated) limit. This operator can emit at most `limitExpr`
number in total.
*
+ * We can not make it inherit [[OrderPreservingUnaryNode]] due to the
different strategy of
+ * physical plan. The output ordering of child will be broken if a shuffle
exchange comes in
+ * between the child and global limit.
+ *
* See [[Limit]] for more information.
Review Comment:
I think "We can ..." should be after "See [[Limit]] for more information."?
It reads like there are more info about `OrderPreservingUnaryNode` in `Limit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
