Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/6194#issuecomment-102463555
  
    @zhzhan Here is a rough list of my updates:
    
    1.  Rebased to PR #6150, which updated the newly introduced partitioning 
support API
    
        Made corresponding changes according to the new API changes.
    
    1.  `OrcFilters` update
    
        - I worked around the builder state inconsistency issue by employing a 
double-checking mechanism.  Now we can convert a single child of an `And` 
filter even if the other child is inconvertible.
        - Added data type checking, as ORC doesn't accept all Spark SQL atomic 
data types (e.g. timestamp).
    
    1.  Added new tests
    
        Extracted some useful testing utility methods to `SQLTestUtils`, and 
added `NewOrcQuerySuite` based on `ParquetQuerySuite`.
    
    1.  Some regular refactoring
    
        Mainly styling issues and code simplifications.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to