ala commented on code in PR #37228:
URL: https://github.com/apache/spark/pull/37228#discussion_r930895136
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetColumnVector.java:
##########
@@ -75,6 +75,11 @@ final class ParquetColumnVector {
this.isPrimitive = column.isPrimitive();
if (missingColumns.contains(column)) {
+ if (ParquetRowIndexUtil.isRowIndexColumn(column)) {
Review Comment:
It's a string comparison (so O(column name length), but in practice cheaper)
that happens at most once per column per scan task. I believe it's in the same
ballpark as all the other initialization happening at the beginning of the scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
