Jonathancui123 commented on code in PR #37327:
URL: https://github.com/apache/spark/pull/37327#discussion_r932486986
##########
docs/sql-data-sources-csv.md:
##########
@@ -109,7 +109,7 @@ Data source options of CSV can be set via:
<td>read</td>
</tr>
<tr>
- <td><code>inferDate</code></td>
+ <td><code>preferDate</code></td>
<td>false</td>
<td>Whether or not to infer columns that satisfy the
<code>dateFormat</code> option as <code>Date</code>. Requires
<code>inferSchema</code> to be <code>true</code>. When <code>false</code>,
columns with dates will be inferred as <code>String</code> (or as
<code>Timestamp</code> if it fits the <code>timestampFormat</code>).</td>
Review Comment:
```suggestion
<td><code>preferDate</code></td>
<td>false</td>
<td>Whether or not to infer columns that satisfy the
<code>dateFormat</code> option as <code>Date</code>. Inference requires
<code>inferSchema</code> to be <code>true</code>. When <code>false</code>,
columns with dates will be inferred as <code>String</code> (or as
<code>Timestamp</code> if it fits the <code>timestampFormat</code>). When
<code>true</code>, the parser will attempt to parse entries in timestamp
columns as DateType before other fallbacks or failing.</td>
```
What do you think of the following docs change to clarify the behavior?
@cloud-fan @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
