MaxGekk commented on code in PR #37322: URL: https://github.com/apache/spark/pull/37322#discussion_r932499581
########## sql/core/src/test/scala/org/apache/spark/sql/DatasetUnpivotSuite.scala: ########## @@ -305,14 +305,17 @@ class DatasetUnpivotSuite extends QueryTest valueColumnName = "val" ) } - checkErrorClass( + checkError( exception = e, errorClass = "UNPIVOT_VALUE_DATA_TYPE_MISMATCH", - msg = "Unpivot value columns must share a least common type, some types do not: \\[" + - "\"STRING\" \\(`str1#\\d+`\\), " + - "\"INT\" \\(`int1#\\d+`, `int2#\\d+`, `int3#\\d+`, ...\\), " + - "\"BIGINT\" \\(`long1#\\d+L`, `long2#\\d+L`\\)\\];(\n.*)*", - matchMsg = true) + errorSubClass = None, + sqlState = None, Review Comment: Let me add the overloaded method: ```scala protected def checkError( exception: SparkThrowable, errorClass: String, parameters: Map[String, String], matchPVals: Boolean): Unit = ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org