amaliujia commented on code in PR #37287:
URL: https://github.com/apache/spark/pull/37287#discussion_r932539967
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -33,36 +33,37 @@ import org.apache.spark.storage.StorageLevel
abstract class Catalog {
/**
- * Returns the current default database in this session.
+ * Returns the current database/namespace in this session.
Review Comment:
yeah it becomes tricky to document as
1. namespace could be multiple layers, e.g. ns1.ns2.ns3.ns4
2. I guess technically usually people may think database is a single name
(and `.` could be treated as a part of the name than a layer separator).
but keep the `database` will maintain backward understanding as people have
get used to it.
I was thinking a few options
1. database or namespace
2. namespace (database)
3. database (namespace).
I am not sure if there are more clear way to document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
