zhengruifeng commented on code in PR #37304: URL: https://github.com/apache/spark/pull/37304#discussion_r932851912
########## sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala: ########## @@ -2127,6 +2127,15 @@ class Dataset[T] private[sql]( valueColumnName: String): DataFrame = unpivot(ids, Array.empty, variableColumnName, valueColumnName) + /** + * Called from Python as Seq[Column] are easier to create via py4j than Array[Column]. + */ + private[sql] def _unpivot(ids: Seq[Column], Review Comment: > And there are other private Python methods in Dataset (mapInPandas) and RelationalGroupedDataset (flatMapGroupsInPandas). they are also used in test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org