HyukjinKwon commented on code in PR #37349:
URL: https://github.com/apache/spark/pull/37349#discussion_r934060417
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala:
##########
@@ -211,7 +211,7 @@ class DataSourceV2StrategySuite extends PlanTest with
SharedSparkSession {
Or(
LessThanOrEqual(attrInt, 1),
// Functions such as 'Abs' are not supported
Review Comment:
```suggestion
// Functions such as 'Abs' are not pushed down with ANSI mode off
```
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala:
##########
@@ -241,7 +241,7 @@ class DataSourceV2StrategySuite extends PlanTest with
SharedSparkSession {
Or(
EqualTo(attrInt, 1),
// Functions such as 'Abs' are not supported
Review Comment:
```suggestion
// Functions such as 'Abs' are not pushed down with ANSI mode off
```
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala:
##########
@@ -200,7 +200,7 @@ class DataSourceV2StrategySuite extends PlanTest with
SharedSparkSession {
And(
GreaterThan(attrInt, 1),
// Functions such as 'Abs' are not supported
Review Comment:
```suggestion
// Functions such as 'Abs' are not pushed down with ANSI mode off
```
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala:
##########
@@ -173,7 +173,7 @@ class DataSourceV2StrategySuite extends PlanTest with
SharedSparkSession {
testTranslateFilter(LessThanOrEqual(
// Expressions are not supported
// Functions such as 'Abs' are not supported
Review Comment:
```suggestion
// Functions such as 'Abs' are not pushed down with ANSI mode off
```
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala:
##########
@@ -277,7 +277,7 @@ class DataSourceV2StrategySuite extends PlanTest with
SharedSparkSession {
),
And(
// Functions such as 'Abs' are not supported
Review Comment:
```suggestion
// Functions such as 'Abs' are not pushed down with ANSI mode off
```
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2StrategySuite.scala:
##########
@@ -307,7 +307,7 @@ class DataSourceV2StrategySuite extends PlanTest with
SharedSparkSession {
),
Or(
// Functions such as 'Abs' are not supported
Review Comment:
```suggestion
// Functions such as 'Abs' are not pushed down with ANSI mode off
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
