tgravescs commented on code in PR #37268:
URL: https://github.com/apache/spark/pull/37268#discussion_r934673600
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala:
##########
@@ -76,6 +76,11 @@ class ResourceProfile(
executorResources.asJava
}
+ /**
+ * Target executor's resource profile id, used for schedule.
+ */
+ def targetExecutorRpId: Int = id
Review Comment:
this assume resource profile has to know there is a taskResourceProfile.
This also seems to limit you to one executor resource profile that is
compatible? Why can't it match on any number of compatible executors. I
guess with the current implementation you limit it to dynamic allocation off so
that is why you can but I don't want to make API changes based on that limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
