cloud-fan commented on code in PR #37325: URL: https://github.com/apache/spark/pull/37325#discussion_r935119977
########## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala: ########## @@ -132,4 +132,10 @@ case class BatchScanExec( val result = s"$nodeName$truncatedOutputString ${scan.description()} $runtimeFiltersString" redact(result) } + + /** + * Returns the name of this type of TreeNode. Defaults to the class name. + * Note that we remove the "Exec" suffix for physical operators here. + */ + override def nodeName: String = s"BatchScan ${scan.name()}" Review Comment: Can we refactor the code a bit and pass `Table#name` when constructing `BatchScanExec`? I think it's better than adding a new public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org