pan3793 commented on code in PR #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r936168604
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala:
##########
@@ -199,7 +202,37 @@ class SQLAppStatusListener(
}
private def aggregateMetrics(exec: LiveExecutionData): Map[Long, String] = {
- val metricTypes = exec.metrics.map { m => (m.accumulatorId, m.metricType)
}.toMap
+ val accumIds = exec.metrics.map(_.accumulatorId).toSet
+
+ val metricAggregationMap = new mutable.HashMap[String, (Array[Long],
Array[Long]) => String]()
+ val metricAggregationMethods = exec.metrics.map { m =>
+ val optClassName = CustomMetrics.parseV2CustomMetricType(m.metricType)
+ val metricAggMethod = optClassName.map { className =>
+ if (metricAggregationMap.contains(className)) {
+ metricAggregationMap(className)
+ } else {
+ // Try to initiate custom metric object
+ try {
+ val metric = Utils.loadExtensions(classOf[CustomMetric],
Seq(className), conf).head
Review Comment:
I agree that we should keep it as simple as possible. I'm asking because the
simple case class does not work since it doesn't have a no-arg constructor, or
a 1-arg constructor.
```
case class SumMetric(name: String, description: String) extends
CustomSumMetric
```
It took me a while to dig out because it just doesn't work and no WARN/ERROR
logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
