pan3793 commented on PR #37386: URL: https://github.com/apache/spark/pull/37386#issuecomment-1203438797
Oh, I see. `SQLMetrics.createV2CustomMetric` only store the class name instead of the instance itself, then constructing the instance by reflection is necessary. Previous I misunderstand that instances constructed by `Scan#supportedCustomMetrics` will be passed and reused. Could you please enhance the comment of `CustomMetric` to mention the constructor requirements as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
