cloud-fan commented on code in PR #37391:
URL: https://github.com/apache/spark/pull/37391#discussion_r937298399
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala:
##########
@@ -90,6 +93,8 @@ class V2ExpressionBuilder(e: Expression, isPredicate: Boolean
= false) {
}
case Cast(child, dataType, _, true) =>
generateExpression(child).map(v => new V2Cast(v, dataType))
+ case AggregateExpression(aggregateFunction, _, isDistinct, None, _) =>
Review Comment:
since we only translate expressions in logical plan to v2, the agg mode
should always be `Complete`.
```suggestion
case AggregateExpression(aggregateFunction, Complete, isDistinct, None,
_) =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
