dongjoon-hyun commented on code in PR #37293:
URL: https://github.com/apache/spark/pull/37293#discussion_r938141846
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedDeltaBinaryPackedReader.java:
##########
@@ -300,7 +300,8 @@ private void unpackMiniBlock() throws IOException {
bitWidths[currentMiniBlock]);
for (int j = 0; j < miniBlockSizeInValues; j += 8) {
ByteBuffer buffer = in.slice(packer.getBitWidth());
- packer.unpack8Values(buffer, buffer.position(), unpackedValuesBuffer, j);
+ packer.unpack8Values(buffer.array(),
Review Comment:
BTW, I believe it's worth to have another independent JIRA issue because
it's an overhead of that new idea instead of our existing code base, @sunchao
and @LuciferYang . The overhead should be measured on that new idea PR in the
community instead of this PR.
@LuciferYang , please file a new one and link to Parquet JIRA which @sunchao
is going to provide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
