beliefer commented on code in PR #37427:
URL: https://github.com/apache/spark/pull/37427#discussion_r939774001
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala:
##########
@@ -50,7 +50,9 @@ private[sql] object H2Dialect extends JdbcDialect {
Set("ABS", "COALESCE", "GREATEST", "LEAST", "RAND", "LOG", "LOG10", "LN",
"EXP",
"POWER", "SQRT", "FLOOR", "CEIL", "ROUND", "SIN", "SINH", "COS", "COSH",
"TAN",
"TANH", "COT", "ASIN", "ACOS", "ATAN", "ATAN2", "DEGREES", "RADIANS",
"SIGN",
- "PI", "SUBSTRING", "UPPER", "LOWER", "TRANSLATE", "TRIM", "MD5", "SHA1",
"SHA2")
+
Review Comment:
```suggestion
```
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -155,13 +155,18 @@ public String build(Expression expr) {
case "SHA2":
case "MD5":
case "CRC32":
+ case "BIT_LENGTH":
+ case "CHAR_LENGTH":
return visitSQLFunction(name,
Arrays.stream(e.children()).map(c ->
build(c)).toArray(String[]::new));
case "CASE_WHEN": {
List<String> children =
Arrays.stream(e.children()).map(c ->
build(c)).collect(Collectors.toList());
return visitCaseWhen(children.toArray(new
String[e.children().length]));
}
+ case "CONCAT":
+ return visitConcat("CONCAT",
Review Comment:
Please use `visitSQLFunction` instead.
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -154,6 +154,18 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
conn.prepareStatement("INSERT INTO \"test\".\"dept\" VALUES (1,
1)").executeUpdate()
conn.prepareStatement("INSERT INTO \"test\".\"dept\" VALUES (2,
1)").executeUpdate()
+
+ conn.prepareStatement(
+ "CREATE TABLE \"test\".\"employee1\" (dept INTEGER, name TEXT(32), " +
Review Comment:
Why not use `employee` ?
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -1404,6 +1416,7 @@ class JDBCV2Suite extends QueryTest with
SharedSparkSession with ExplainSuiteHel
}
test("scan with filter push-down with string functions") {
+
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
