beliefer commented on code in PR #37320:
URL: https://github.com/apache/spark/pull/37320#discussion_r940873396
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/Cast.java:
##########
@@ -42,4 +42,9 @@ public Cast(Expression expression, DataType dataType) {
@Override
public Expression[] children() { return new Expression[]{ expression() }; }
+
+ @Override
+ public String toString() {
Review Comment:
No, some V2 expressions missing `toString` too. e.g. `Extract`.
Add a default implementation in the base class Expression using
`ToStringSQLBuilder` is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
