cloud-fan commented on code in PR #37415: URL: https://github.com/apache/spark/pull/37415#discussion_r941439129
########## sql/core/src/test/resources/sql-tests/results/udaf.sql.out: ########## @@ -31,7 +31,7 @@ SELECT default.myDoubleAvg(int_col1, 3) as my_avg from t1 struct<> -- !query output org.apache.spark.sql.AnalysisException -Invalid number of arguments for function spark_catalog.default.myDoubleAvg. Expected: 1; Found: 2; line 1 pos 7 +Invalid number of arguments for function spark_catalog.default.mydoubleavg. Expected: 1; Found: 2; line 1 pos 7 Review Comment: This was a test problem before: we forgot to lower-case the function name when creating functions, and the testing in-memory catalog is case-preserving. This is inconsistent with table creation and should be fixed. Note that the production behavior (with Hive Metastore) is not changed: Hive Metastore is not case-preserving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
