mridulm commented on code in PR #37384:
URL: https://github.com/apache/spark/pull/37384#discussion_r941817602
##########
core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala:
##########
@@ -108,6 +110,10 @@ class TaskInfo(
}
}
+ private[spark] def launchSucceeded: Unit = {
Review Comment:
`def launchSucceeded` -> `def launchSucceeded()`
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -1067,11 +1067,14 @@ private[spark] class TaskSetManager(
}
}
for ((tid, info) <- taskInfos if info.running && info.executorId ==
execId) {
+ // If the task is launching, this indicates that Driver has sent
LaunchTask to Executor,
+ // but Executor has not sent StatusUpdate(TaskState.RUNNING) to Driver.
Hence, we assume that
+ // the task is not running, and it is NetworkFailure rather than
TaskFailure.
Review Comment:
Move the comment to the `!info.launching` case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
