MaxGekk commented on code in PR #37452:
URL: https://github.com/apache/spark/pull/37452#discussion_r942610741
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala:
##########
@@ -71,6 +76,30 @@ trait SQLQueryTestHelper {
if (isSorted(df.queryExecution.analyzed)) (schema, answer) else (schema,
answer.sorted)
}
+ private def toJson(e: SparkThrowable): String = {
Review Comment:
Generating the JSON file is a small piece of code. Don't see any problem to
remove/move it in the near future. And introduce the config, and then check it
on the already existing golden files.
> What we have here now is a hand crafted JSON.
How else would you generate JSON from `SparkThrowable`, I wonder.
> Is that temporary?
Not final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
