huaxingao commented on code in PR #37393:
URL: https://github.com/apache/spark/pull/37393#discussion_r942657907
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/PredicateUtils.scala:
##########
@@ -132,4 +133,16 @@ private[sql] object PredicateUtils {
case _ => None
}
}
+
+ def toV1(
+ predicates: Array[Predicate],
+ skipIfNotConvertible: Boolean): Array[Filter] = {
Review Comment:
I actually have thought about this, this works OK for `SupportsDelete`, but
we will have to throw Exception later on for `SupportsOverwrite`, because we
don't have an API `canOverwrite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
